Switch axiom replay to use exact rather than a custom apply variant#1029
Open
oskgo wants to merge 1 commit into
Open
Switch axiom replay to use exact rather than a custom apply variant#1029oskgo wants to merge 1 commit into
exact rather than a custom apply variant#1029oskgo wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates theory cloning’s axiom replay mechanism to use the standard apply … exact path (rather than a custom ExactType apply variant), addressing the reported anomaly during reduction/typing in the presence of parametric axioms/subtypes.
Changes:
- Switch axiom override replay in
ecThCloningto generate anapply … exacttactic instead of the customExactTypeapply mode. - Remove the
ExactTypeconstructor from the parsetree and delete the corresponding processing code inecHiGoal. - Add a regression test covering cloning an axiom with a more polymorphic lemma (
tests/clone-parametric-axiom.ec).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/clone-parametric-axiom.ec | Adds a regression test for cloning a parametric axiom overridden by a polymorphic lemma. |
| src/ecThCloning.ml | Changes axiom replay tactic generation to use apply with Exact mode. |
| src/ecParsetree.ml | Removes the ExactType apply variant from the AST. |
| src/ecHiGoal.ml | Removes the implementation handling the deleted ExactType variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1006 (comment), but not the other issues, which are orthogonal.
The custom apply variant was introduced by #312. I don't understand why that was done. It seems unrelated to the example in #292.